mcvsubbu commented on a change in pull request #3675: Sslbranch
URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288688102
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java
##########
@@ -270,6 +333,14 @@ public String getControllerPort() {
return (String) getProperty(CONTROLLER_PORT);
}
+ public String getControllerHttpsPort() {
+ if (!containsKey(CONTROLLER_HTTPS_PORT)) {
+ return "443";
Review comment:
Can you please add a static final for the default port like the other
configurations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
