xiaohui-sun commented on a change in pull request #4984: [TE] Fix
over-scheduling tasks in data availability scheduler
URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367111150
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskScheduler.java
##########
@@ -58,18 +59,29 @@
private ScheduledExecutorService executorService;
private long delayInSec;
private long fallBackTimeInSec;
+ private long schedulingWindowInSec;
private Map<Long, Long> taskLastCreateTimeMap;
private TaskManager taskDAO;
private DetectionConfigManager detectionConfigDAO;
private DatasetConfigManager datasetConfigDAO;
+
+ private class DatasetUpdateStatus {
+ long lastDataTs;
Review comment:
Add comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
