xiaohui-sun commented on a change in pull request #4984: [TE] Fix
over-scheduling tasks in data availability scheduler
URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367116114
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskScheduler.java
##########
@@ -119,7 +135,8 @@ public void close() {
}
private void populateDetectionMapAndDataset2RefreshTimeMap(
- Map<DetectionConfigDTO, Set<String>> dataset2DetectionMap, Map<String,
Long> dataset2RefreshTimeMap) {
+ Map<DetectionConfigDTO, Set<String>> dataset2DetectionMap,
Review comment:
I have a feeling we are creating too many customized objects. Can we just
reuse the DatasetConfigDTO and get rid of DatasetUpdateStatus? The
DatasetConfigDTO should contain everything you need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
