xiaohui-sun commented on a change in pull request #4984: [TE] Fix
over-scheduling tasks in data availability scheduler
URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367112698
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskScheduler.java
##########
@@ -89,12 +101,16 @@ public void run() {
long detectionConfigId = detectionConfig.getId();
if (!runningDetection.containsKey(detectionConfigId)) {
if (isAllDatasetUpdated(detectionConfig,
detection2DatasetMap.get(detectionConfig), dataset2RefreshTimeMap)) {
- //TODO: additional check is required if detection is based on
aggregated value across multiple data points
- createDetectionTask(detectionConfig);
- ThirdeyeMetricsUtil.eventScheduledTaskCounter.inc();
- taskCount++;
+ if
(isWithinSchedulingWindow(detection2DatasetMap.get(detectionConfig),
dataset2RefreshTimeMap)) {
+ //TODO: additional check is required if detection is based on
aggregated value across multiple data points
+ createDetectionTask(detectionConfig);
+ ThirdeyeMetricsUtil.eventScheduledTaskCounter.inc();
+ taskCount++;
+ } else {
+ LOG.warn("Unable to schedule a task for {}, because it is out of
scheduling window.", detectionConfigId);
Review comment:
Should we log it? Will it creates lots of logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
