shibd commented on code in PR #258:
URL:
https://github.com/apache/pulsar-client-node/pull/258#discussion_r1043293220
##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -58,7 +58,6 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.nodejs }}
- cache: 'npm'
Review Comment:
> If we choose to check in the npm lock file, it's strange that we run CI
tasks with yarn.
For users, when the user execution `npm install pulsar-client` or `yarn add
pulsar-client`. they are not using pulsr-clien's npm lock file(we are not
uploading package.lock.json to the npm registry).
We are experiencing an issue where users can install successfully with npm
but fail with yarn. So, The use of yarn here is to verify the scene of
`pulsar-client` installed by the user using `yarn`.
> What if moving the pkg manager to yarn totally?
If so, just in case. We also need to verify the installation using npm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
