shibd commented on code in PR #258:
URL: 
https://github.com/apache/pulsar-client-node/pull/258#discussion_r1043295599


##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -58,7 +58,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.nodejs }}
-          cache: 'npm'

Review Comment:
   > I think we'd better not. The motivation is to prevent the regression 
happened again. I think we can add a separated workflow to verify the yarn 
install in a single env like Linux.
   
   Reuse the current workflow to save CI execution time. `yarn install` command 
can take tens of seconds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to