sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for
batch message local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r379151918
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -54,6 +54,7 @@ message MessageIdData {
required uint64 entryId = 2;
optional int32 partition = 3 [default = -1];
optional int32 batch_index = 4 [default = -1];
+ repeated int64 ackSet = 5;
Review comment:
```suggestion
repeated int64 ack_set = 5;
```
the naming convention should be consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
