sijie commented on issue #6052: [PIP-54] Acknowledgement for batch message local index URL: https://github.com/apache/pulsar/pull/6052#issuecomment-586010416 @codelipenghui I think the change looks very good in general. However, there are a few major comments I would like to clarify here. 1) we should be consistent using the name across the client, broker and storage layers. I think we should call the bitmap `ack_set` at client and broker layers. but we should call it `delete_set` at the storage layer (ML part). 2) bookkeeper has a good implementation of `WriteSet` and `AckSet` that leverage netty recycle objects. we should leverage that implementation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
