sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for
batch message local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r379160010
##########
File path: managed-ledger/src/main/proto/MLDataFormats.proto
##########
@@ -78,6 +81,11 @@ message MessageRange {
required NestedPositionInfo upperEndpoint = 2;
}
+message BatchDeletedIndexInfo {
+ required NestedPositionInfo position = 1;
+ repeated int64 ackBitSet = 2;
Review comment:
A few comments here:
1) I would prefer calling it `delete_set`. "Acknowledgement" is the concept
at the client & broker side. In managed ledger level, we use "delete". So it is
better to keep the name consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
