Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r555053085
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfiguration.java
##########
@@ -63,6 +63,10 @@
public static final String METADATA_FIELD_MAX_BLOCK_SIZE =
"maxBlockSizeInBytes";
public static final String METADATA_FIELD_READ_BUFFER_SIZE =
"readBufferSizeInBytes";
public static final String OFFLOADER_PROPERTY_PREFIX =
"managedLedgerOffload";
+ public static final String MAX_SEGMENT_TIME_IN_SECOND =
"maxSegmentTimeInSecond";
+ public static final long DEFAULT_MAX_SEGMENT_TIME_IN_SECOND = 600;
+ public static final String MAX_SEGMENT_SIZE_IN_BYTES =
"maxSegmentSizeInBytes";
+ public static final long DEFAULT_MAX_SEGMENT_SIZE_IN_BYTES = 1024 * 1024 *
1024;
Review comment:
Do you mean segment may become larger than `MAX_SEGMENT_SIZE_IN_BYTES`
if the time it reaches `MAX_SEGMENT_SIZE_IN_BYTES` is shorter than
`minOffloadSegmentRolloverTimeInSeconds`? If so, maybe we need a
`REAL_MAX_SEGMENT_SIZE_IN_BYTES` to avoid the segment become too big.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
