Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r555433897
##########
File path: managed-ledger/src/main/proto/MLDataFormats.proto
##########
@@ -32,12 +32,23 @@ message OffloadDriverMetadata {
}
message OffloadContext {
- optional int64 uidMsb = 1;
- optional int64 uidLsb = 2;
- optional bool complete = 3;
- optional bool bookkeeperDeleted = 4;
- optional int64 timestamp = 5;
- optional OffloadDriverMetadata driverMetadata = 6;
+ optional int64 uidMsb = 1;
+ optional int64 uidLsb = 2;
+ optional bool complete = 3;
+ optional bool bookkeeperDeleted = 4;
+ optional int64 timestamp = 5;
+ optional OffloadDriverMetadata driverMetadata = 6;
+ repeated OffloadSegment offloadSegment = 7;
+}
+
+message OffloadSegment {
+ optional int64 uidMsb = 1;
+ optional int64 uidLsb = 2;
+ optional bool complete = 3;
+ optional int64 assignedTimestamp = 5; //timestamp in millisecond
+ optional int64 offloadedTimestamp = 6; //timestamp in millisecond
+ optional int64 endEntryId = 7;
+ optional OffloadDriverMetadata driverMetadata = 8;
Review comment:
But others are not consistent with each other, some use 4 spaces, some
use 2 spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
