Renkai commented on a change in pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#discussion_r555060115
########## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/StreamingOffloadIndexBlock.java ########## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.offload.jcloud; + +import java.io.Closeable; +import java.io.FilterInputStream; +import java.io.IOException; +import java.io.InputStream; +import java.util.Map; +import org.apache.bookkeeper.client.api.LedgerMetadata; +import org.apache.bookkeeper.common.annotation.InterfaceStability.Unstable; + +/** + * The Index block abstraction used for offload a ledger to long term storage. + */ +@Unstable +public interface StreamingOffloadIndexBlock extends Closeable { Review comment: We not only add some fields at the index header but also make the content repeatable, it actually makes every method in the `OffloadIndexBlock` a bit different from before. If we reuse `OffloadIndexBlock`, I think the methods of `OffloadIndexBlock` will be doubled, and we need to use extra checks to make sure users use the right version of a method, I don't think it will make less duplicate code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
