Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r555073182



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -594,4 +593,6 @@ void asyncSetProperties(Map<String, String> properties, 
final AsyncCallbacks.Upd
      * Get the ManagedLedgerInterceptor for ManagedLedger.
      * */
     ManagedLedgerInterceptor getManagedLedgerInterceptor();
+
+    CompletableFuture<LedgerMetadata> getRawLedgerMetadata(long ledgerId);

Review comment:
       > Can you explain why do we need this method? Also, add a comment to 
this method?
   
   Former offloader get a `ReadHandle` from `ManagedLedger`, and get 
`LedgerMetadata` from `ReadHandle`, our new offloader does not hold any 
`ReadHandle` but it still needs `LedgerMetadata` to make the block index




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to