Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r555079372



##########
File path: 
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloaderBase.java
##########
@@ -82,7 +71,11 @@ protected static MockZooKeeper createMockZooKeeper() throws 
Exception {
                 CreateMode.PERSISTENT);
         return zk;
     }
-    
+
+    protected static MockManagedLedger createMockManagedLedger() {

Review comment:
       `BlobStoreManagedLedgerOffloaderBase` is a class for test, not 
implementation. Its name doesn't like a test class, but you can see its 
directory 
`src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloaderBase.java`
 is a test directory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to