Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r555075983



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -594,4 +593,6 @@ void asyncSetProperties(Map<String, String> properties, 
final AsyncCallbacks.Upd
      * Get the ManagedLedgerInterceptor for ManagedLedger.
      * */
     ManagedLedgerInterceptor getManagedLedgerInterceptor();
+
+    CompletableFuture<LedgerMetadata> getRawLedgerMetadata(long ledgerId);

Review comment:
       Actually, I want to name this method to `getLedgerMetadata`, but a 
method with this name already exists 
https://github.com/apache/pulsar/blob/138390ca27a49682cb9d0a0ff256c01e1bc347e3/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L1685
 
   Maybe it's better to name the existing method `getLedgerMetadataStr`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to