sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200293704
##########
File path:
tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/runtime/PulsarFunctionsRuntimeTest.java
##########
@@ -57,7 +58,7 @@ public PulsarFunctionsRuntimeTest(ContainerFactory
containerFactory) {
@Test(dataProvider = "FunctionRuntimes")
public void testExclamationFunction(Runtime runtime) throws Exception {
- if (ContainerFactory.THREAD == containerFactory && Runtime.PYTHON ==
runtime) {
+ if (functionProcessingMode == FunctionProcessingMode.THREAD && runtime
== Runtime.PYTHON) {
Review comment:
sure. if you would like to introduce this coding convention, I would
recommend doing it in a separate PR, and describe that clearly in the PR's
description. or introduce checkstyle to enforce this coding convention.
because this change here doesn't belong to this PR, it is unrelated to any
other changes in PR.
when people look back to the git history, it is really hard to know why did
you change this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
