sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200022516
##########
File path:
tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/runtime/PulsarFunctionsRuntimeTest.java
##########
@@ -33,22 +33,23 @@
import
org.apache.pulsar.tests.integration.functions.utils.CommandGenerator.Runtime;
import org.apache.pulsar.tests.topologies.PulsarCluster;
import org.testcontainers.containers.Container.ExecResult;
+import org.testng.annotations.Factory;
import org.testng.annotations.Test;
/**
* The tests that run over different container mode.
*/
public abstract class PulsarFunctionsRuntimeTest extends
PulsarFunctionsTestBase {
- protected enum ContainerFactory {
+ public enum FunctionProcessingMode {
Review comment:
This is not *processing mode*. If you want to rename it, I would prefer
renaming it to 'RuntimeFactory' to keep the naming consistent with what
functions is using -
https://github.com/apache/incubator-pulsar/blob/master/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeFactory.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
