sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200021707
##########
File path:
tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTestBase.java
##########
@@ -50,11 +51,20 @@ protected static String getExclamationClass(Runtime
runtime) {
}
@BeforeClass
- public static void setupCluster() throws Exception {
- PulsarClusterTestBase.setupCluster();
+ public void setupCluster() throws Exception {
+ setupClusterForProcess();
+ }
+ public void setupClusterForProcess() throws Exception {
Review comment:
since you change static method to class method, it is better to move
`setupClusterForProcess` to `PulsarFunctionsProcessRuntimeTest` and move
`setupClusterForThread` to `PulsarFunctionsProcessThreadTest`. there is no need
to put these two classes in the parent class.
That means:
- remove `setupCluster` from this class.
- move `setupClusterForProcess` to `PulsarFunctionsProcessRuntimeTest` as
`setupCluster`
- move `setupClsuterForThread` to `PulsarFunctionsThreadRuntimeTest` as
`setupCluster`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
