CosmosNi commented on code in PR #11103:
URL: https://github.com/apache/seatunnel/pull/11103#discussion_r3426536124
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -98,7 +98,7 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
}
@Override
- public void finishAndCloseFile() {
+ public synchronized void finishAndCloseFile() {
Review Comment:
Recommend fixing this at the MultiTableSinkWriter level rather than
per-connector,Writing needs to be suspended when performing a checkpoint.
Otherwise the same race persists for all multi-table sinks,such as StarRocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
