DanielLeens commented on code in PR #11103:
URL: https://github.com/apache/seatunnel/pull/11103#discussion_r3451577526
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -98,7 +98,7 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
}
@Override
- public void finishAndCloseFile() {
+ public synchronized void finishAndCloseFile() {
Review Comment:
Thanks, @CosmosNi. That sounds good to me. I still agree the framework-level
checkpoint/write coordination deserves a separate STIP or follow-up design
discussion, but on this unchanged PR head I do not have a new source-level
finding beyond what we already discussed in this thread. If you or the author
push code that changes the current file-sink fix, please ping again and I will
re-review the latest head from scratch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
