davidzollo commented on code in PR #11103:
URL: https://github.com/apache/seatunnel/pull/11103#discussion_r3446273440
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -98,7 +98,7 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
}
@Override
- public void finishAndCloseFile() {
+ public synchronized void finishAndCloseFile() {
Review Comment:
> I believe conflicts arising from checkpoint writes should be resolved at
the API layer rather than handled separately within each connector. This
per-connector implementation approach will inevitably lead to missing fixes and
inconsistent handling across connectors.
Yes, you're right, would you like to start a STIP to solve it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
