DanielLeens commented on code in PR #11103:
URL: https://github.com/apache/seatunnel/pull/11103#discussion_r3446407809
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -98,7 +98,7 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
}
@Override
- public void finishAndCloseFile() {
+ public synchronized void finishAndCloseFile() {
Review Comment:
Yes, I think a STIP is the right long-term place to solve this at the
framework/API layer.
For this PR itself, I would still keep the targeted file-sink fix: the
current change closes a real race on the concrete write/checkpoint path that
users can hit today, while the API-level coordination contract is a broader
design topic that should be discussed and applied consistently across
connectors in a follow-up. In other words, I see the STIP as the next
architectural step, not as a reason to hold this bugfix open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
