nzw921rx commented on code in PR #11103:
URL: https://github.com/apache/seatunnel/pull/11103#discussion_r3427893019
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -98,7 +98,7 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
}
@Override
- public void finishAndCloseFile() {
+ public synchronized void finishAndCloseFile() {
Review Comment:
我认为 `MultiTableSinkWriter` 是统一的 connector API 契约层,他聚合调用多个`SinkWriter`
在 `MultiTableSinkWriter` 加入此破坏了 API边界，且 `MultiTableSinkWriter` 并不需要处理此类情况
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
