DanielLeens commented on code in PR #11103:
URL: https://github.com/apache/seatunnel/pull/11103#discussion_r3427493738
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/CanalJsonWriteStrategy.java:
##########
@@ -98,7 +98,7 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
}
@Override
- public void finishAndCloseFile() {
+ public synchronized void finishAndCloseFile() {
Review Comment:
Thanks @CosmosNi. I rechecked your point against the current head, and I
agree the more complete fix should live in the shared `MultiTableSinkWriter`
checkpoint/write coordination path. Otherwise the same race can survive in
other multi-table sinks as well. Since there is still no new commit after
`2101a32`, I am not starting another full review round on unchanged code.
@zhangshenghang, once you push an update for the shared writer path, please
ping me and I will re-review the latest head from scratch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
