DanielLeens commented on issue #11617:
URL: https://github.com/apache/seatunnel/issues/11617#issuecomment-5152722917

   Thanks for the detailed root-cause analysis. I checked the current `dev` 
code and the diagnosis matches the implementation: the incremental split path 
in `MySqlBinlogFetchTask` still creates a plain 
`MySqlStreamingChangeEventSource`, while the stop-offset check exists only in 
the snapshot backfill wrapper.
   
   There is now an open fix PR linked to this issue: #11618. It targets `dev`, 
is not a draft, and GitHub reports it as mergeable, but it still needs review 
and the current Build check is failing.
   
   Let's continue the technical review in #11618. For the PR to be safe to 
merge, please make sure it includes focused coverage for:
   
   1. bounded incremental read with `stop.mode = "specific"`;
   2. the unbounded `stop.mode = "never"` path, so streaming jobs cannot be 
marked finished accidentally;
   3. mixed/partial GTID offset comparison if that remains part of the fix;
   4. the fetcher completion path that returns split completion only for 
bounded reads.
   
   Keeping the issue open and associated with #11618 until the PR is reviewed, 
CI is green, and merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to