nielifeng commented on issue #11617: URL: https://github.com/apache/seatunnel/issues/11617#issuecomment-5163361868
The cross-connector audit requested here found one remaining blocker in #11618. The PR's shared IncrementalSourceStreamFetcher.isBoundedReadFinished() uses !stopOffset.isNeverStop(), but only MySQL BinlogOffset overrides the new base method. PostgreSQL, SQL Server, Oracle, and MongoDB all return their own NO_STOPPING_OFFSET from StopConfig.NEVER, and those offset classes still inherit the base false.\n\nBecause all four use the shared reader, their valid stop.mode="never" split is currently indistinguishable from a bounded split once the fetch task reaches isFinished(); the fetcher can return null and the reader interprets that as split completion. #11618 needs either sentinel overrides plus real non-MySQL regression coverage, or an explicit boundedness contract that does not rely on a default-false offset method. I am not opening a duplicate PR because this belongs in the existing fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
