DanielLeens commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5251995058
Thanks for the detailed diagnosis, and for rerunning the full `connector-cdc-mysql-e2e` module rather than just the one test this PR touches. I agree with your read: `MysqlCDCWithFlinkSchemaChangeIT.testMysqlCdcWithSchemaEvolutionCase` failing on `ConditionTimeout` in `assertSchemaEvolutionForAddColumns` is a known-flaky test, not a regression from this PR. That test has a DDL-vs-binlog-initialization race under loaded CI runners that shows up intermittently even on PRs that never touch schema-change code, and this PR's diff genuinely doesn't touch that file. The fact that this PR's own new test, `MysqlCDCIT#testMysqlCdcContinuesAfterSinkFailure`, passed cleanly on the same run (along with the rest of the 107-test module) is the evidence that matters for this PR specifically. From Daniel's side the only remaining item was CI turning green — the production fix and unit test have been settled for a while now. Since this is an unrelated flaky test, a rerun of the failed job should be enough to get a clean gate; no code change needed here. Feel free to retrigger it, and ping me if it comes back red with something that isn't the same schema-evolution test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
