li3zhi4 commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5265110113
@SEZ9 — re: the two findings behind the standing `CHANGES_REQUESTED` (submitted against head `1684c382f`, now two commits behind), I verified both against the current head `779c961f3` and they do not hold up against the actual diff. @DanielLeens reached the same conclusion in his reviews; sharing the concrete evidence here so the review state can be reconciled. **Issue 1 (High, "Possible public API change"):** the only production-code change to `IncrementalSourceEnumerator` is `public void addSplitsBack(List<SourceSplitBase>, int)` → `public synchronized void addSplitsBack(List<SourceSplitBase>, int)` — `synchronized` is a modifier, not part of the method signature. Method name, parameter types, and return type are byte-for-byte unchanged, so no binary or source compatibility break for downstream connectors. The other production changes are comment-only: `SourceSplitEnumerator.java` (javadoc clarification, no code) and `SourceSplitEnumeratorTask.java` (7 lines of comments). **Issue 2 (Low, "Config/option changes without doc updates"):** this PR adds zero configuration surface — no `Option` class, no config key, no doc-worthy setting. The only `.conf` file in the diff is the e2e test resource `mysqlcdc_to_mysql_with_sink_failure_recovery.conf`, which is test scaffolding, not product configuration. Since both findings were repeated verbatim across the two `CHANGES_REQUESTED` reviews and the underlying concerns are resolved in the current head (which you already acknowledged in your comment — the three pre-merge asks were addressed), could you submit a fresh review on `779c961f3` or dismiss/update the existing `CHANGES_REQUESTED`? The formal review state currently blocks merge at the GitHub level (`reviewDecision: REVIEW_REQUIRED`). Happy to address anything that still looks wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
