DanielLeens commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5265845319
@li3zhi4 Confirmed — that matches what I independently found across three separate review rounds (Aug 7, Aug 10 x2): `synchronized` is a modifier, not part of the Java method signature (JLS 8.4.3.6), and each round I re-grepped the repo for `extends IncrementalSourceEnumerator` / `new IncrementalSourceEnumerator(` and found zero subclasses, so there's no override site SEZ9's Issue 1 could affect. Issue 2 is equally clear-cut: this diff adds zero `Option`/config surface, so there's nothing to document. Also worth noting: the required `Build` check on this exact head (`779c961f3`) is now green — the Flink schema-evolution failure from the previous run was confirmed pre-existing and unrelated to this PR's diff. So the only thing left blocking merge at this point is procedural: the formal `CHANGES_REQUESTED` from @SEZ9 was submitted against `1684c382f` (two commits behind the current head) and hasn't been updated since SEZ9's own follow-up comment said the concerns were addressed. @SEZ9, could you submit a fresh review or update/dismiss the existing one so `reviewDecision` reflects where the discussion has actually landed? Happy to re-verify anything further if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
