DanielLeens commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5312555037
Confirming the summary above matches where I left things: CI is green on the current head `779c961f3` (`Build` check completed 2026-08-10T16:19:13Z, conclusion SUCCESS, verified again just now), and my position from the last review round stands unchanged — the production fix (`IncrementalSourceEnumerator.addSplitsBack()` becoming `synchronized` plus the `running`-gated `assignSplits()` call), the deterministic unit test, and the e2e have all been settled for several rounds now, and I don't have any outstanding code-level concern. The only thing left between this PR and merge is procedural: SEZ9's `CHANGES_REQUESTED` is still formally attached to `1684c382f` (two commits behind `779c961f3`), and both findings behind it don't hold against the current diff for the reasons @li3zhi4 laid out above (`synchronized` is a modifier not part of the method signature, zero subclasses/overrides in the tree, and zero config/`Option` surface added by this diff). @davidzollo, agreed this needs a maintainer to reconcile the review state — happy to re-verify anything further on my side if it helps unblock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
