li3zhi4 commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5311101417
@davidzollo — reaching out as a maintainer since this PR's merge is blocked purely by a stale review state, not by any outstanding code issue. Summary of where things stand: **Status of PR #11677** ([Fix][Connector-CDC] Reassign restored splits to waiting readers after checkpoint recovery): - **CI: fully green** on head `779c961f3` — `Build` check is `success` (verified via check-runs API; the earlier Flink schema-evolution e2e failure was confirmed pre-existing and unrelated, and a rerun passed). - **@DanielLeens**: "Ready to merge after fixes" — independently re-traced the production fix and unit test across multiple rounds and confirmed the only remaining item was CI green (now resolved) and the review-state update below. - **@SEZ9**: his formal review is `CHANGES_REQUESTED`, but it was submitted against head `1684c382f` (two commits behind the current head), and both findings behind it (possible public API change; missing config docs) don't hold against the current diff — verified with concrete evidence: `synchronized` is a modifier, not part of the Java method signature, with zero subclasses of `IncrementalSourceEnumerator` in the repo; and the diff adds zero `Option`/config surface. SEZ9 himself confirmed in a comment (Aug 9) that the concerns were addressed, but never updated the formal review state, so GitHub still reports `reviewDecision: REVIEW_REQUIRED` and blocks merge. We and @DanielLeens have both asked SEZ9 to update/dismiss it, without response since. Since the code, tests, and CI are all settled and both reviewers have substantively approved, could you help unblock the merge — e.g. dismiss the stale `CHANGES_REQUESTED` or nudge @SEZ9 to update his review? Happy to provide anything else needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
