SEZ9 commented on PR #11648: URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5385642186
Thanks @loustler — the split plan looks good to me, and it's a nice outcome that this PR is no longer a breaking change once the shade module (and the `seatunnel-hadoop3-3.1.4-uber` → `seatunnel-hadoop3-3.4.3-uber` rename) drops out of scope. Remaining items before this can move forward: 1. Please rebase once the 3.4.3 shade artifacts are published to Central, since this PR can't build until then. 2. During the rebase, drop the `incompatible-changes.md` entry that only documented the rename, and confirm nothing else remaining in scope still qualifies as a breaking change — as @DanielLeens noted, nothing obvious does, but worth double-checking. 3. Since @DanielLeens's earlier approval on `5799a570` covered the pre-split head, a fresh review will be needed on the rebased PR — please ping us when it's ready. I can't speak to the shade release turnaround myself; that question is best raised with the seatunnel-shade maintainers. Thanks for keeping this well-scoped! <!-- streview-comment:485 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
