tagadearpit commented on PR #11950:
URL: https://github.com/apache/seatunnel/pull/11950#issuecomment-5385939989
Thanks for reviewing this fix.
The issue is reproducible under `tr-TR`: the previous implementation returns
`lower("I") = "ı"` and `upper("i") = "İ"` because it uses the JVM default
locale. This patch switches both functions to `Locale.ROOT`, preserving null
behavior and making SQL transformations deterministic across workers.
A regression test temporarily sets the Turkish locale, verifies `lower("I")
= "i"` and `upper("i") = "I"`, and restores the original locale in a `finally`
block.
Validation completed:
- `StringFunctionTest`: 34 passed.
- - Transforms module verification: passed.
- - Spotless formatting/check: passed.
- - Pre-fix harness reproduced `lower=ı upper=İ`.
- - Post-fix harness passed with `lower=i upper=I`.
The full repository commands were attempted as well; their failures are
unrelated to this change and occur in the config-shade/frontend environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
