DanielLeens commented on PR #11950:
URL: https://github.com/apache/seatunnel/pull/11950#issuecomment-5433282283
Quick follow-up after re-checking the current head (`585b7fe`).
The only commit added since my last review is `585b7fe` ("ci: trigger pull
request build"), which is an empty commit — zero files changed. So the PR diff
is still byte-identical to what I already reviewed: just `StringFunction.java`
(`Locale.ROOT` on the two case-conversion calls) and the new
`testLowerAndUpperAreIndependentOfDefaultLocale` test. Nothing new to re-review
on the code side, so I'm not posting another full review for the same code
version.
I did dig into why the `Build` check is now showing red, since that's new
information since my last comment. The three failing jobs on the fork run are
all unrelated to this PR's module:
- `engine-v2-it (11, ubuntu-latest)`:
`SinkErrorToMysqlIT.testSinkMaxErrorRatioThreshold` timed out after 2 minutes
waiting for a lingering `HikariPool` housekeeper thread and a
`st-multi-table-sink-writer` thread to exit inside the test container — a
known-flaky thread-teardown timing issue in an unrelated MySQL
sink-error-handling IT, nothing to do with SQL transforms.
- `doris-connector-it (11, ubuntu-latest)`: `DorisErrorIT` failed with
`UnknownHostException: doris_e2e: Temporary failure in name resolution` — a
Docker-network DNS resolution flake reaching the Doris test container.
- `connector-file-local-it (8, ubuntu-latest)`: Maven build failure
resolving `flink-annotations:1.20.1` from Maven Central (`Connection reset`) —
a transient artifact-download failure, not a test/code failure at all.
None of these touch `seatunnel-transforms-v2` or exercise
`StringFunction`/case-conversion code in any way, so my prior "Ready to merge"
conclusion stands unchanged. This looks like ordinary CI flakiness across three
independent lanes rather than anything caused by this change — a rerun of those
three jobs should clear it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
