DanielLeens commented on PR #10973: URL: https://github.com/apache/seatunnel/pull/10973#issuecomment-5593901569
Thanks for closing these out. 5. Confirmed — the description now spells out that `sass-embedded` is `optional`/`peer` after the swap to `sass`, so a plain `npm install` won't drag in the `@bufbuild/protobuf` chain via a hard dependency anymore. That fully answers the concern. 4. That's the right call — no local npm installs/builds here either, per the same rule. Leaving `--ignore-scripts` as a non-blocking manual follow-up note for whoever deploys that way is fine with me; I don't think it's worth a dedicated CI step just for this. On the CI failures: agreed those are unrelated (Doris stream-load visibility and the Postgres CDC snapshot-startup timeout are both known flaky areas, not touched by this UI-only change), and re-running just the failed jobs rather than the whole workflow is the right approach. `Build` is green now. With both outstanding items resolved and CI passing, I'm good with this from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
