SEZ9 commented on PR #10973: URL: https://github.com/apache/seatunnel/pull/10973#issuecomment-5594767462
@DanielLeens — thanks for the follow-up, and sorry for the slow reply. Agreed with your summary: items 1–3 were already confirmed, and 4 and 5 were the only remaining points, both Low/non-blocking. On 5 (protobuf lock-entry note): @davidzollo has added the note to the PR description explaining that `sass-embedded` is now an optional peer entry rather than a hard dependency, so a plain `npm install` no longer force-installs the protobuf chain. You've confirmed that closes the concern, so I consider this resolved. On 4 (`--ignore-scripts` / native watcher install script): agreed with the call not to run local npm installs/builds for this PR — GitHub CI is authoritative here. Since you're fine leaving it as a non-blocking manual follow-up note rather than a dedicated CI step, I'm treating it as closed for this review. On CI: aligned with both of you that the `all-connectors-it-7` and `doris-connector-it` failures on `2f9f7341693` are unrelated to this `seatunnel-engine-ui`-only change, and re-running just the failed jobs was the right approach. With the rerun green and `Build` passing, I have no remaining asks from my side. <!-- streview-comment:902 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
