SEZ9 commented on PR #10973: URL: https://github.com/apache/seatunnel/pull/10973#issuecomment-5611825757
Thanks @DanielLeens — agreed on the summary, nothing to add on substance. For the record from my side: - Items 1–3 (in-file MIT attribution for the Ionicons path data, the `registry.npmmirror.com` lockfile provenance, and the `npm install --omit=dev` claim vs. the devDependencies move) stand as resolved from the earlier rounds. - Item 4 (`--ignore-scripts` / native watcher install script) stays as we left it: a non-blocking manual follow-up note for anyone deploying that way, no dedicated CI step. I still haven't run it locally, per the local-verification rule, so I'm not claiming otherwise. - Item 5 (protobuf lock entry / `sass-embedded` now `optional`/`peer`) is covered by the PR description note you confirmed. Head is still `2f9f73416937` with no new commits since the last round, as you re-checked, and I have nothing further open on this PR. What's left is procedural: as you noted, your account is comment-only here, so the approving review and merge need to come from a maintainer with write access. No further changes are needed from the author before that. <!-- streview-comment:937 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
