SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5724665482
Thanks for the follow-up on the CI runs and the Kotlin inventory. **F4 / F6 (Kotlin stdlib versions).** The comment above reports that at `5cde0fdd8ce8ace10b688010f968bfeeee61d6b0` both `tools/dependencies/known-dependencies.txt` and `seatunnel-dist/release-docs/LICENSE` list the four `kotlin-stdlib*` entries uniformly at `1.9.10`, with no `1.8.21` entry. If that's what is on the head, the inventory-side mismatch in F6 is resolved and I'll drop it. For F4, what remains is the runtime side: could you share the resolved kotlin-stdlib / okhttp3 versions on the Zeta server module's classpath so we can confirm it is also uniformly 1.9.10? If it isn't, please pin the version explicitly rather than relying on nearest-wins resolution. **F1 (E2E wait strategy).** Understood that `engine-v2-it (11, ubuntu-latest)` reached `connector-console-seatunnel-e2e` and passed `FakeSourceToConsoleWithEventReportIT`, while the JDK 8 leg stopped at module `66/67` on an unrelated failure and never started module 67. I'm fine not blocking on the JDK 8 gap. However, a green run doesn't address the finding itself: setting the `received new worker register` wait strategy in `executeExtraCommands` happens after the container lifecycle is configured/started, so it isn't gating server readiness — the test passes on timing rather than on the wait. Please move the wait strategy into the container configuration so it is applied as part of startup. **F2, F3, F5, F7, F8.** I haven't seen a response to these yet. Could you either push changes or comment on each? - F2/F3: `close()` behavior when the scheduler doesn't terminate — concurrent flush with the still-running task, `evictAll()` not reclaiming in-flight connections, and only `HazelcastInstanceNotActiveException`/`IOException` being caught. - F5: `takeRequest()` without a timeout in `testRetryAfterHttpFailure`, the leaked request `Buffer`s, and the implicit assumption that the scheduler fires immediately despite the 1-day interval. - F7: `OkHttpClient` following redirects by default with the configured report headers attached. - F8: whether `RequestBody.create(String, MediaType)` appending `; charset=utf-8` changes the `Content-Type` that existing collectors receive. Once F1 is moved and the F4 runtime versions are confirmed, the remaining items are small and I'd expect this to be ready. <!-- streview-comment:1140 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
