SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6096309869
@ryanmeowy, thanks for opening #12708 — that PR is now the review surface for the MySQL and inherited OceanBase validation slice, so let's keep implementation discussion and CI evidence there rather than on this issue. The design direction stands as agreed: runtime source path unchanged, connector-local per-offset-option guards so an omitted `startup.mode` is still checked when a `startup.specific-offset.*` value is present, plus a separate `specific` conditional requiring file and pos together. Remaining asks before this is ready for human review: - The Build check on #12708 has been reported as failing. Please resolve it on the PR; if it turns out to be the Spotless / google-java-format 1.7 step you flagged as unrunnable on local JDK 21, note that in the PR so reviewers can tell a formatting fix from a logic fix. - Preserve the reviewed compatibility matrix while fixing CI: file + pos only remains valid under `specific`; GTID and the two skip values stay optional with their nonblank/nonnegative constraints only when present; every explicit and omitted wrong-mode specific-offset case fails during configuration validation; and the OceanBase inheritance tests stay green. - Once CI is green on the `0278a6a74` rebase, drop a short note on the PR and I'll take it from there. <!-- streview-comment:1645 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
