SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6137438885
Classification: I / Declarative OptionRule migration tracking. @ryanmeowy, following up on the MySQL and inherited OceanBase validation slice in #12708 only. Status as last recorded here: the PR was rebased on `dev` at `0278a6a74`, carries the static `startup.specific-offset.*` check in the MySQL factory's `optionRule()`, 9 new tests in `MySqlIncrementalSourceFactoryTest`, and 3 inheritance tests in `OceanBaseIncrementalSourceFactoryTest`. The last note on this thread was that the Build check for #12708 had failed; nothing since then has reported whether that is resolved. Remaining asks before this slice can move to human review: 1. Please post on #12708 (not here) whether the Build check now passes after the rebase, and if Spotless / google-java-format 1.7 was the cause, confirm it is fixed in the PR rather than only noted in the description. 2. Confirm the reviewed compatibility matrix is still intact in the final tests: file + pos only remains valid for `specific`; GTID and the two skip values stay optional with nonblank/nonnegative constraints only when present; every explicit wrong-mode and every omitted-`startup.mode` specific-offset case fails during configuration validation; the OceanBase inheritance cases remain covered. 3. Confirm the runtime source path is unchanged — no OptionRule DSL or runtime-path change is part of this slice. @nzw921rx, for your review tracking: #12708 is the review surface for MySQL + OceanBase; its readiness is gated on the CI evidence above. <!-- streview-comment:1716 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
