ryanmeowy commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6121094267
Continuing with the same connector-cdc row, this time `connector-cdc-mongodb`. `MongodbSourceConfigProvider`'s builder setters still assert `batch.size >= 0`, `poll.max.batch.size > 0`, `poll.await.time.ms > 0`, `heartbeat.interval.ms >= 0` and `incremental.snapshot.chunk.size.mb > 0`. Those five options are already registered through `optional(...)`, so section A's range conditions cover them. The two that only fire while the job is being created are more interesting. `MongodbIncrementalSourceFactory` rejects an empty `schema` or an empty `tables_configs`, which is the `exclusive(SCHEMA, TABLE_CONFIGS)` plus `mapNotEmpty` / `notEmpty` combination from D2. `MongodbSourceConfigProvider.Builder#validate` rejects a `stop.timestamp` that does not resolve to a position after `startup.timestamp`, comparing the derived change-stream offsets because MongoDB change-stream timestamps only have second precision, so that one needs a `ConditionExtension` to keep the same comparison. I am extending `MongodbIncrementalSourceFactoryTest` to cover each of the above. Taking it if nobody else has it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
