DanielLeens commented on PR #11613: URL: https://github.com/apache/seatunnel/pull/11613#issuecomment-6143684769
@SEZ9 a small clarification that may save a round trip: @davidzollo's comment above is not actually cut off. It continues past item 3 with items 4 to 8, and I checked each of them against the current head `9dc0aede18` (the code is the same as what I reviewed there): - Item 4 (local-only UUID validation behind a load balancer / reverse proxy): documented as a limitation in `docs/en/engines/zeta/rest-api-v2.md:1479` and `docs/en/engines/zeta/web-ui.md:159` (zh mirrors it). - Item 5 (dedicated `/update-local-member-tags` section): present in `rest-api-v2.md` with request, success response and an error table. - Item 6 (Restore Latest State vs. a still-running source job): implemented server-side in `JobInfoService.validateCheckpointRestoreRequest` (`JobInfoService.java:536`), called from the three submit paths (lines 461, 494, 514), covered by `JobInfoServiceRestoreGuardTest` and `RestApiSubmitJobStartWithSavePointTest#testSubmitCheckpointRestoreFromActiveSourceJobReturns400`, and recorded in `incompatible-changes.md`. - Item 7 (`/http-service/status` field table and example ports): per-field table plus 8080/8443 example values in `rest-api-v2.md` (around lines 1766-1800). - Item 8 (screenshots): still open, as @davidzollo says. I flagged it as non-blocking in my last review. On CI: the current head `9dc0aede18` still has only the `Build` check in `action_required` and no fork run, so none of the new tests have executed yet. The minimal next step is the fork owner enabling Actions on the fork (as discussed above); nothing else needs to be added to the PR for that. Thanks both for the careful follow-up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
