Nikk8091 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6161331580
Hi, I would also like to request a separate `connector-cdc-postgres` Source validation slice for future work. On current `dev` (`25bcc53f`), `PostgresIncrementalSourceFactory.optionRule()` requires `JdbcCommonOptions.URL` for presence but does not reject an explicitly empty or whitespace-only URL. The tracker still lists this connector as Todo, and I did not find an open PR implementing this specific validation rule. I propose adding only a declarative `notBlank(JdbcCommonOptions.URL)` constraint and focused factory/`ConfigValidator` coverage for valid, missing, empty, whitespace-only, and padded nonblank URL values. I will preserve the existing table-selection and startup rules, URL parsing, credentials, connection/retry behavior, and all runtime checks. I will check the EN/ZH connector docs against the final behavior. This would be its own Postgres CDC PR against `dev`, not combined with the DB2 claim. Could you confirm that this independent scope is available? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
