karthik-0306 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6383491023
@SEZ9 @DanielLeens a quick update and a proposal. #12858 has no open review items left (only CI: the remaining red job is the known `BackpressureSlowSinkIT` flake, which I'll re-run), and #12857 is approved. I've gone through the rest of the launcher end to end and would like to build it through to the finish, delivered the same way as so far: one small PR at a time, each only after the previous one lands, with you reviewing. First, an answer to open question 3 from your split: I checked `downloads.apache.org`, and `seatunnel/3.0.0/` has `apache-seatunnel-3.0.0-bin.tar.gz` (~472 MB) plus `.sha512` and `.asc`, and `seatunnel/KEYS` exists, so URL construction can rely on that layout. Proposed order for the remaining PR 1 pieces: 1. Version → tarball URL resolution and a per-user, per-version cache directory (outside `site-packages`) 2. Streamed download + sha512 verification, aborting **without extracting** on mismatch, then extraction into the cache 3. `.asc` signature verification against `KEYS` (signature mismatch aborts without extracting) 4. Generated per-user config that moves the checkpoint namespace off `/tmp/seatunnel/checkpoint_snapshot` 5. Local-mode run via subprocess (`bin/seatunnel.sh` / `seatunnel.cmd` with `-m local`) and `seatunnel.run(...)` on top 6. Cluster submit reusing the SDK's `jobs.submit_job` 7. The acceptance tests from the issue (fresh venv `FakeSource -> Console`, checksum/signature mismatch, offline second run) plus docs in `docs/en` and `docs/zh` PR 2 (PyPI name, release path, console script) stays with the PMC. I'd only prepare the code once that's decided, especially since `seatunnel-cli` already uses the `seatunnel` command. Three things I'd like your view on before the relevant step: - **Signature check (step 3):** shell out to the `gpg` CLI (no new Python dependency, mirroring how `install-plugin.sh` probes for hash tools), or add a dependency? - **Mirror / offline override name:** something like `SEATUNNEL_DIST_REPOSITORY`, to match `SEATUNNEL_MAVEN_REPOSITORY`? - **First target version:** 3.0.0, since it's the only one with the full set of release files? If you'd rather keep any of these pieces yourself, just tell me and I'll skip it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
