hutiefang76 commented on PR #12592: URL: https://github.com/apache/seatunnel/pull/12592#issuecomment-6392767161
@SEZ9, checked again on unchanged `cb6ae01c`: - **F1:** `reconvert` does honour scale: 9 maps back to `TIMESTAMP_NS`; 0/3/6 map to `TIMESTAMP_S`/`TIMESTAMP_MS`/`TIMESTAMP`. Intermediate scales widen to the next native precision. See [the mapping](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBTypeConverter.java#L342) and `testReconvertTimestampFollowsDeclaredPrecision` / `testReconvertTimestampWidensIntermediatePrecision` in `DuckDBTypeConverterTest`. This is implemented, not deferred. - **F3/F8:** The WARN is still WARN, but only once per converter when a non-null alias value reaches the pre-epoch legacy fallback. Post-epoch and NULL reads do not trigger it. The [converter Javadoc](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverter.java#L94-L175) explicitly states that detection uses metadata, is driver-version-independent, and will not automatically adopt a future typed getter. - **F5/F7:** Metadata lookup is already cached per `ResultSet`, with cache rebuilding on a result-set change; `testAliasMetadataIsReadOncePerResultSet` and `testAliasDecisionsAreRebuiltWhenTheResultSetChanges` cover that. Only the call-local `Calendar` allocation and the cached `ResultSet` reference/lifecycle remain follow-up work. They are recorded in [Daniel's existing review follow-up](https://github.com/apache/seatunnel/pull/12592#issuecomment-6383295238); there is no separate tracking issue. <sub>AI-assisted reply (Codex), checked against the linked revision.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
