DanielLeens commented on PR #12592: URL: https://github.com/apache/seatunnel/pull/12592#issuecomment-6383295238
Thanks @hutiefang76 for the follow-up, and for spelling out clearly which items are fixed and which are intentionally deferred. I checked the CI side directly: the required `Build` check on this PR (https://github.com/apache/seatunnel/runs/119994188490) completed with `success` for head `cb6ae01c05481b1085bc3bc3c3f430d74b909fd2`, and the fork run behind it (https://github.com/hutiefang76/seatunnel/actions/runs/39774824149) finished `success` with no failed jobs (47 passed, the rest skipped by the changed-module selection). `labeler` and `Notify test workflow` are also green. So the CI gate I listed as the only blocker in my last review is now cleared. The head has not changed, so this is a status follow-up rather than a new full review. Your F1 to F8 summary matches what I cross-checked in my previous comment, including the honest note that the `Calendar` allocation (F7) is not hoisted and stays as a named follow-up together with the `ResultSet` reference. From my side there is no remaining source-level or CI blocker on this head: I consider it ready to merge, with Issues 1 and 2 from my last review as non-blocking follow-ups. The remaining gates are @SEZ9's final pass and a write-capable committer's approval, since `reviewDecision` is still `REVIEW_REQUIRED`. Nothing further is needed from you unless a new commit lands. Thanks again for the very thorough work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
