hutiefang76 commented on PR #12592: URL: https://github.com/apache/seatunnel/pull/12592#issuecomment-6379044974
@SEZ9, here is the rest in a shorter form, checked against the unchanged `cb6ae01c`: - **F1/F4:** The source now exposes timestamp scale to every downstream sink; each sink's converter determines its DDL. The [upgrade note](https://github.com/apache/seatunnel/blob/cb6ae01c/docs/en/introduction/concepts/incompatible-changes.md#L127) lists MySQL, PostgreSQL, SQL Server and Oracle. For plain DuckDB `TIMESTAMP`, MySQL automatic DDL now uses `DATETIME(6)` instead of the previous unqualified `DATETIME`. Existing tables are not resized. - **F2/F6:** Historical alias reads are **not corrected** by this PR. Values before the epoch still use the legacy getter. The [regression](https://github.com/apache/seatunnel/blob/cb6ae01c/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBSourceAndSinkTest.java#L1255) pins the 1918 DST-gap and 1582 cutover shifts in four zones through both source modes; the note documents them as deferred limitations. - **F3/F8:** In the [row converter](https://github.com/apache/seatunnel/blob/cb6ae01c/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverter.java#L94-L175), the WARN runs once only when the pre-epoch fallback is reached, without a version literal. The Javadoc states that metadata detection is version-independent and will not automatically adopt a future typed getter. - **F5/F7:** The same converter caches column decisions per `ResultSet` and rebuilds them when it changes. `Calendar` allocation remains call-local and deferred, as agreed in the earlier review; it has not been hoisted. I am not claiming that part is fixed. No source change in this reply. The earlier 115-test result still applies to this head; the required PR Build remains a separate gate. <sub>AI-generated reply, prepared with Codex and DeepSeek; source claims verified against the linked revision.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
