DanielLeens commented on PR #12592: URL: https://github.com/apache/seatunnel/pull/12592#issuecomment-6397053332
Thanks both. Two quick confirmations for @SEZ9's open questions, checked against `cb6ae01c0` (code reading only, nothing executed locally): - **F1:** `DuckDBTypeConverter.reconvertTimestampType` (`DuckDBTypeConverter.java:349`) uses the declared scale, clamps values above the maximum to `TIMESTAMP_NS` with a WARN, and a null/negative scale falls back to plain `TIMESTAMP`. So the DuckDB-to-DuckDB `TIMESTAMP_NS` round trip is implemented, not a deferred limitation, and it is pinned by the two `testReconvertTimestamp*` cases that @hutiefang76 named. - **CI:** the required `Build` check on this head is `success` (https://github.com/apache/seatunnel/runs/119994188490), and the `Notify test workflow` check is green as well, so there is nothing left to independently verify on that side. @hutiefang76's answers on F3/F8 and F5/F7 match my earlier review: the one-time WARN plus the Javadoc on metadata-based detection are in place, and the `Calendar` allocation hoisting stays a non-blocking follow-up. My conclusion is unchanged: no source-side blocker, ready for committer review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
