hutiefang76 commented on PR #12592: URL: https://github.com/apache/seatunnel/pull/12592#issuecomment-6358135675
Thanks @SEZ9. I checked each item against `cb6ae01c` and reran all 115 DuckDB tests successfully. Most of these changes are already present; these links should make them easier to locate: - **F1:** [`reconvertTimestampType`](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBTypeConverter.java#L349) preserves the declared scale, including `TIMESTAMP_NS`. The [native-DDL tests](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBTypeConverterTest.java#L495) and [real sink round trip](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBSourceAndSinkTest.java#L198) both passed again. Other sinks consume that scale according to their own converter; the [upgrade note](https://github.com/apache/seat unnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/docs/en/introduction/concepts/incompatible-changes.md#L127) describes the PostgreSQL, SQL Server and Oracle mappings too. - **F2/F6:** The known historical read limitation remains deliberately deferred. [`testPreEpochAliasReadsKeepTheLegacyGetterForDstGapAndCutover`](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBSourceAndSinkTest.java#L1255) already covers the 1918 gap and 1582 cutover in four zones through both read modes, and passed in this run. It pins the shifts rather than claiming to correct them. - **F3:** The warning is called [only inside the pre-epoch fallback](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverter.java#L106), and its [message](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverter.java#L132) contains no driver version. - **F4:** The standard `TIMESTAMP` → MySQL `DATETIME(6)` change is explicit in [English](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/docs/en/introduction/concepts/incompatible-changes.md#L127) and [Chinese](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/docs/zh/introduction/concepts/incompatible-changes.md#L112). - **F5:** [Per-ResultSet alias decisions](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverter.java#L158) are already cached, with [metadata-call and ResultSet-switch tests](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverterTest.java#L55). - **F7:** Calendar allocation remains the named follow-up [agreed was non-blocking on October 21](https://github.com/apache/seatunnel/pull/12592#issuecomment-6308105577). It stays call-local because the driver receives a mutable Calendar; I have not changed that lifecycle in this PR. - **F8:** The [alias Javadoc](https://github.com/apache/seatunnel/blob/cb6ae01c05481b1085bc3bc3c3f430d74b909fd2/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/duckdb/DuckDBJdbcRowConverter.java#L145) explicitly describes version-independent metadata detection and the fact that a future typed getter will not be adopted automatically. The required PR Build still needs its own result. The supplemental Edge Agent run does not replace it. <sub>AI-generated reply, prepared with Codex and DeepSeek; checks and results verified against the current source.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
