lyndonb-bq opened a new pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515


   # Summary
   The following gremlin-python features and bugs are addressed in this pull 
request:
   - Remote Transaction support (`g.tx()`)
   - Logging framework
   - Bug where improper cleanup causes `aiohttp` stack trace pop up
   - Fixed a bit of general code formatting throughout the library
   
   ## Related tickets
   [TINKERPOP-2555 - g.tx() support for 
gremlin-python](https://issues.apache.org/jira/browse/TINKERPOP-2555)
   [TINKERPOP-? - Support for logger in gremlin-python](?)
   [TINKERPOP-? - Improper closing of gremlin-python driver causes 
exceptions](?)
   
   ## High level overview of individual changes made
   ### Source:
   1.  Added `neo4j-gremlin` dependency to `pom.xml`, fixed issue with 
`TEST_TRANSACTION` environment variable.
   2. Made `DriverRemoteConnection` latch parameters so they can be reused to 
create a subsequent session
   3. Added logging throughout the driver
   4. Added `commit` and `rollback` to `DriverRemoteConnection`
   5. Added some logging to receive message
   6. Added transaction support to `RemoteConnection`
   6. Added `Bytecode` support to `Session` `processor`
   7. Fixed bug in `aiohttp` transport layer that popped up when it was not 
shutdown properly
   8. Added `Transaction` class to `graph_traversal.py`, added `tx` function 
which generates a `Transaction`
   9. Added `create_graph_op `method that allows a simple `Bytecode` with 
source to be created
   10. Added `GraphOp` class with `commit` and `rollback` functions which 
return `Bytecode` for `commit` and `rollback`
   
   ### Test:
   1. Enhance test configuration to have `remote_transaction_connection`
   2. Updated `submitAsync` -> `submit_async` for `test_client`
   3. Added transaction test to exercise basic `commit`
   4. Added transaction test to exercise basic `rollback`
   5. Added transaction test to exercise multi `commit`
   6. Added transaction test to exercise multi `rollback`
   7. Added transaction test to exercise multi `commit` and `rollback` together
   8. Added transaction test to exercise illegal operations (negative test)
   
   ### Documentation:
   1. Added documentation for gremlin-python usage
   2. Updated CHANGELOG to include `g.tx()` support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to